-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/646/
-----------------------------------------------------------

(Updated 2011-04-22 04:22:16.136899)


Review request for hive, Yongqiang He and namit jain.


Changes
-------

execute() not to throw any exception.


Summary
-------

now when CommandNeedRetryException is thrown, locks are not released. Not sure 
whether it will cause problem, since the same locks will be acquired when 
retrying it. It is anyway something we need to fix. Also we can do some little 
code cleaning up to make future mistakes less likely.


This addresses bug HIVE-2123.
    https://issues.apache.org/jira/browse/HIVE-2123


Diffs (updated)
-----

  trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 1095838 
  trunk/hwi/src/java/org/apache/hadoop/hive/hwi/HWISessionItem.java 1095838 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java 1095838 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/processors/CommandProcessor.java 
1095838 

Diff: https://reviews.apache.org/r/646/diff


Testing
-------


Thanks,

Siying

Reply via email to