[
https://issues.apache.org/jira/browse/HIVE-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13031386#comment-13031386
]
jirapos...@reviews.apache.org commented on HIVE-243:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/626/
-----------------------------------------------------------
(Updated 2011-05-10 21:25:03.998477)
Review request for hive.
Changes
-------
- First ctrl+c will print a message and try to stop the current command. Second
ctrl+c will kill the jvm
- Added code that stops some of the JDO processing
- Now the code can also stop generating input summary.
- Fixed loop in Utilities.getInputSummary that hangs under some conditions
Summary
-------
Fixed by adding INT signal hander that interrupts the CLI thread. The CLI
thread gets InterruptedException and it stops the current command.
This addresses bug HIVE-243.
https://issues.apache.org/jira/browse/HIVE-243
Diffs (updated)
-----
trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 1100312
trunk/common/src/java/org/apache/hadoop/hive/common/HiveInterruptCallback.java
PRE-CREATION
trunk/common/src/java/org/apache/hadoop/hive/common/HiveInterruptUtils.java
PRE-CREATION
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java
1100312
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java
1100312
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1100312
Diff: https://reviews.apache.org/r/626/diff
Testing
-------
Manual test Ctrl+C on bunch of command (show tables, select, etc)
Thanks,
georgedj
> ^C breaks out of running query, but not whole CLI
> -------------------------------------------------
>
> Key: HIVE-243
> URL: https://issues.apache.org/jira/browse/HIVE-243
> Project: Hive
> Issue Type: Wish
> Components: Query Processor
> Affects Versions: 0.8.0
> Reporter: Adam Kramer
>
> It would be lovely if, when I know a query is bad, I could just ^C out of it.
> I can do that now, but the whole CLI quits.
> It'd be quite nice if it took an extra ^C to break the CLI, or if there was
> some control character to break out of a query without breaking out of the
> CLI.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
