----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/742/#review667 -----------------------------------------------------------
Ship it! Thanks Chinna for the cleanup work. Looks good to me. - Ashutosh On 2011-05-13 11:07:56, chinna wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/742/ > ----------------------------------------------------------- > > (Updated 2011-05-13 11:07:56) > > > Review request for hive. > > > Summary > ------- > > Few code improvements in the metastore,hwi and ql packages. > 1) Little performance Improvements > 2) Effective varaible management. > > > This addresses bug HIVE-2160. > https://issues.apache.org/jira/browse/HIVE-2160 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/hive/trunk/hwi/src/java/org/apache/hadoop/hive/hwi/HWISessionItem.java > 1101752 > > http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 1101752 > > http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java > 1101752 > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ColumnPrunerProcFactory.java > 1101752 > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMRUnion1.java > 1101752 > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/MapJoinProcessor.java > 1101752 > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/unionproc/UnionProcessor.java > 1101752 > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/FetchWork.java > 1101752 > > Diff: https://reviews.apache.org/r/742/diff > > > Testing > ------- > > Ran all tests > > > Thanks, > > chinna > >