-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/777/
-----------------------------------------------------------
(Updated 2011-06-08 00:55:49.148248)
Review request for hive and John Sichi.
Changes
-------
Addressed Ning's comments. After testing on the cluster, I ran into the coarse
timeout a few times, so I think it makes sense to have a fine timeout on
grabbing the task completions and then proceed with the rest of the JobDebugger
stuff. I have added a separate configuration variable to toggle the timeout for
grabbing task completions, we may just want to scale the overall timeout by
some factor.
Summary
-------
- Add local error messages to point to job logs and provide TaskIDs
- Add a timeout to the fetching of task logs and errors
This addresses bug HIVE-2156.
https://issues.apache.org/jira/browse/HIVE-2156
Diffs (updated)
-----
build-common.xml a2236e1
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java b94cdc6
conf/hive-default.xml 1317a9c
ql/build.xml 449b47a
ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java 40d2644
ql/src/java/org/apache/hadoop/hive/ql/exec/JobDebugger.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/MapRedTask.java 53769a0
ql/src/java/org/apache/hadoop/hive/ql/exec/MapredLocalTask.java 691f038
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java ec816e9
ql/src/test/queries/clientnegative/minimr_broken_pipe.q PRE-CREATION
ql/src/test/results/clientnegative/dyn_part3.q.out 5f4df65
ql/src/test/results/clientnegative/index_compact_entry_limit.q.out fcb2673
ql/src/test/results/clientnegative/index_compact_size_limit.q.out fcb2673
ql/src/test/results/clientnegative/minimr_broken_pipe.q.out PRE-CREATION
ql/src/test/results/clientnegative/script_broken_pipe1.q.out d33d2cc
ql/src/test/results/clientnegative/script_broken_pipe2.q.out afbaa44
ql/src/test/results/clientnegative/script_broken_pipe3.q.out fe8f757
ql/src/test/results/clientnegative/script_error.q.out c72d780
ql/src/test/results/clientnegative/udf_reflect_neg.q.out f2082a3
ql/src/test/results/clientnegative/udf_test_error.q.out 5fd9a00
ql/src/test/results/clientnegative/udf_test_error_reduce.q.out ddc5e5b
ql/src/test/templates/TestNegativeCliDriver.vm ec13f79
Diff: https://reviews.apache.org/r/777/diff
Testing
-------
Tested TestNegativeCliDriver in both local and miniMR mode
Thanks,
Syed
