[
https://issues.apache.org/jira/browse/HIVE-956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13046355#comment-13046355
]
He Yongqiang commented on HIVE-956:
-----------------------------------
Maybe i can be more specific,
LazyBinaryColumnarSerDe and LazyBinarySerde share a lot of code when doing
serialization. can warnedOnceNullMapKey be removed?
>>A 0 in this recorded length is used as the null indicator.
A 0 should mean an empty string. '\N' means null in Hive. Can you take a look
at how LazyBinarySerde handles null value, and do the same thing here?
I prefer to remove getLength(), it will make the code more clean. In the
implementation, it is actually only checks for primitives, which actually can
produce wrong results.
>>Do you think I should create a dependant jira and extract this part of the
>>patch to that jira?
Yes, pls do that.
> Add support of columnar binary serde
> ------------------------------------
>
> Key: HIVE-956
> URL: https://issues.apache.org/jira/browse/HIVE-956
> Project: Hive
> Issue Type: New Feature
> Reporter: He Yongqiang
> Assignee: Krishna Kumar
> Attachments: HIVE.956.patch.0, HIVE.956.patch.1, HIVE.956.patch.2
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
