[ 
https://issues.apache.org/jira/browse/HIVE-2211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13046840#comment-13046840
 ] 

Ning Zhang commented on HIVE-2211:
----------------------------------

+1. In the followup we should add a unit test for this function to compare the 
contentsummary returned by parallel execution and serial execution. 

> Fix a bug caused by HIVE-243
> ----------------------------
>
>                 Key: HIVE-2211
>                 URL: https://issues.apache.org/jira/browse/HIVE-2211
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Siying Dong
>         Attachments: HIVE-2211.1.patch
>
>
> Quick fix a bug caused by HIVE-243
> HIVE-234 removed the codes to wait for the threads to finish and use 
> ThreadPoolExector.shutdown() to wait for the results. The usage of 
> ThreadPoolExecutor.shutdown(), however, is wrong. The codes assume that the 
> function blocks until all threads finish running but it actually only marks 
> status and won't block. It caused wrong result of Utilities.getInputSummary() 
> and caused many jobs are executed as local mode while they have huge data.
> Revert those changes quickly. We can have a follow-up to see how to deal with 
> this more efficiently if you want.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to