----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/883/#review843 -----------------------------------------------------------
Ship it! Looks good to me. Thanks for making the changes. - Carl On 2011-06-14 20:51:53, Ashutosh Chauhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/883/ > ----------------------------------------------------------- > > (Updated 2011-06-14 20:51:53) > > > Review request for hive and John Sichi. > > > Summary > ------- > > Follow-up for HIVE-2147. > > > This addresses bug HIVE-2215. > https://issues.apache.org/jira/browse/HIVE-2215 > > > Diffs > ----- > > trunk/metastore/if/hive_metastore.thrift 1135779 > > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 1135779 > > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > 1135779 > > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java > 1135779 > > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java > 1135779 > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java > 1135779 > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java > 1135779 > > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/LoadPartitionDoneEvent.java > PRE-CREATION > > trunk/metastore/src/model/org/apache/hadoop/hive/metastore/model/MPartitionEvent.java > PRE-CREATION > trunk/metastore/src/model/package.jdo 1135779 > > trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyListener.java > 1135779 > > trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMarkPartition.java > PRE-CREATION > > trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMarkPartitionRemote.java > PRE-CREATION > > trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java > 1135779 > > Diff: https://reviews.apache.org/r/883/diff > > > Testing > ------- > > Added test cases for new api. > > > Thanks, > > Ashutosh > >
