[ https://issues.apache.org/jira/browse/HIVE-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13050841#comment-13050841 ]
jirapos...@reviews.apache.org commented on HIVE-2213: ----------------------------------------------------- ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/878/#review858 ----------------------------------------------------------- trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java <https://reviews.apache.org/r/878/#comment1877> Can we make this method parameterized to reduce the number of casts required? E.g. private <T> Collection <T> getPartition... We might have to do something like <String>getPartition... when making the call though. - Paul On 2011-06-16 23:30:02, Sohan Jain wrote: bq. bq. ----------------------------------------------------------- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/878/ bq. ----------------------------------------------------------- bq. bq. (Updated 2011-06-16 23:30:02) bq. bq. bq. Review request for hive and Paul Yang. bq. bq. bq. Summary bq. ------- bq. bq. If a table has a large number of partitions, get_partition_names_ps() make take a long time to execute, because we get all of the partition names from the database. This is not very memory efficient, and the operation can be pushed down to the JDO layer without getting all of the names first. bq. bq. bq. This addresses bug HIVE-2213. bq. https://issues.apache.org/jira/browse/HIVE-2213 bq. bq. bq. Diffs bq. ----- bq. bq. trunk/common/src/java/org/apache/hadoop/hive/common/FileUtils.java 1135227 bq. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1135227 bq. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 1135227 bq. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 1135227 bq. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java 1135227 bq. trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java 1135227 bq. bq. Diff: https://reviews.apache.org/r/878/diff bq. bq. bq. Testing bq. ------- bq. bq. Passes previous test cases for get_partition_names_ps() in TestHiveMetaStore. bq. bq. bq. Thanks, bq. bq. Sohan bq. bq. > Optimize get_partition_names_ps() > --------------------------------- > > Key: HIVE-2213 > URL: https://issues.apache.org/jira/browse/HIVE-2213 > Project: Hive > Issue Type: Improvement > Components: Metastore > Reporter: Sohan Jain > Assignee: Sohan Jain > Attachments: HIVE-2213.1.patch, HIVE-2213.3.patch > > > If a table has a large number of partitions, get_partition_names_ps() make > take a long time to execute, because we get all of the partition names from > the database. This is not very memory efficient, and the operation can be > pushed down to the JDO layer without getting all of the names first. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira