-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/878/
-----------------------------------------------------------
(Updated 2011-06-17 21:22:00.028428)
Review request for hive and Paul Yang.
Changes
-------
- made getPartitionPsQueryResults() return a parameterized type to avoid lots
of casting
Summary
-------
If a table has a large number of partitions, get_partition_names_ps() make take
a long time to execute, because we get all of the partition names from the
database. This is not very memory efficient, and the operation can be pushed
down to the JDO layer without getting all of the names first.
This addresses bug HIVE-2213.
https://issues.apache.org/jira/browse/HIVE-2213
Diffs (updated)
-----
trunk/common/src/java/org/apache/hadoop/hive/common/FileUtils.java 1136751
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
1136751
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java
1136751
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java
1136751
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java
1136751
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java
1136751
Diff: https://reviews.apache.org/r/878/diff
Testing
-------
Passes previous test cases for get_partition_names_ps() in TestHiveMetaStore.
Thanks,
Sohan
