[ https://issues.apache.org/jira/browse/HIVE-1218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13065507#comment-13065507 ]
jirapos...@reviews.apache.org commented on HIVE-1218: ----------------------------------------------------- ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1057/#review1062 ----------------------------------------------------------- http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like.q <https://reviews.apache.org/r/1057/#comment2134> Why are you doing DESCRIBE FORMATTED twice for these tables? http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_like.q.out <https://reviews.apache.org/r/1057/#comment2135> Shouldn't this be EXTERNAL_TABLE? - John On 2011-07-14 18:54:32, Charles Chen wrote: bq. bq. ----------------------------------------------------------- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/1057/ bq. ----------------------------------------------------------- bq. bq. (Updated 2011-07-14 18:54:32) bq. bq. bq. Review request for hive. bq. bq. bq. Summary bq. ------- bq. bq. https://issues.apache.org/jira/browse/HIVE-1218 bq. bq. bq. This addresses bug HIVE-1218. bq. https://issues.apache.org/jira/browse/HIVE-1218 bq. bq. bq. Diffs bq. ----- bq. bq. http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1146841 bq. http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1146841 bq. http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableLikeDesc.java 1146841 bq. http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like.q 1146841 bq. http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like_view.q PRE-CREATION bq. http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_like.q.out 1146841 bq. http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_like_view.q.out PRE-CREATION bq. bq. Diff: https://reviews.apache.org/r/1057/diff bq. bq. bq. Testing bq. ------- bq. bq. Unit tests passed bq. bq. bq. Thanks, bq. bq. Charles bq. bq. > CREATE TABLE t LIKE some_view should create a new empty base table, but > instead creates a copy of view > ------------------------------------------------------------------------------------------------------ > > Key: HIVE-1218 > URL: https://issues.apache.org/jira/browse/HIVE-1218 > Project: Hive > Issue Type: Bug > Components: Metastore > Affects Versions: 0.5.0 > Reporter: John Sichi > Assignee: Charles Chen > Attachments: HIVE-1218v0.patch, HIVE-1218v2.patch, HIVE-1218v3.patch > > > I think it should copy only the column definitions from the view metadata. > Currently it is copying the entire descriptor, resulting in a new view > instead of a new base table. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira