----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1058/#review1063 -----------------------------------------------------------
http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java <https://reviews.apache.org/r/1058/#comment2136> For a partitioned view, won't this drop all the existing partitions? We don't want that. - John On 2011-07-14 00:45:22, Charles Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1058/ > ----------------------------------------------------------- > > (Updated 2011-07-14 00:45:22) > > > Review request for hive. > > > Summary > ------- > > https://issues.apache.org/jira/browse/HIVE-1078 > > > This addresses bug HIVE-1078. > https://issues.apache.org/jira/browse/HIVE-1078 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java > 1146520 > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g > 1146520 > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > 1146520 > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateViewDesc.java > 1146520 > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_view.q.out > 1146520 > > Diff: https://reviews.apache.org/r/1058/diff > > > Testing > ------- > > Passes unit tests > > > Thanks, > > Charles > >