-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1010/#review1112
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/index/HiveIndexQueryContext.java
<https://reviews.apache.org/r/1010/#comment2271>

    Why was this comment truncated?



ql/src/test/queries/clientpositive/index_auto_mult_tables.q
<https://reviews.apache.org/r/1010/#comment2273>

    All of these SELECT statements need ORDER BY for determinism.


- John


On 2011-07-19 03:15:17, Syed Albiz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1010/
> -----------------------------------------------------------
> 
> (Updated 2011-07-19 03:15:17)
> 
> 
> Review request for hive and John Sichi.
> 
> 
> Summary
> -------
> 
> Grab the indexed tables during optimized query generation, grab the 
> associated path URIs, and keep those around in the Configuration object. When 
> the job is passed to ExecDriver, this data is extracted and used in 
> HiveIndexedInputFormat to decide whether to use the index file or delegate to 
> the parent (HiveInputFormat) class. Not sure if this is robust. 
> 
> 
> This addresses bug HIVE-2128.
>     https://issues.apache.org/jira/browse/HIVE-2128
> 
> 
> Diffs
> -----
> 
>   ql/src/test/results/clientpositive/index_auto_self_join.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/index_auto_mult_tables_compact.q.out 
> PRE-CREATION 
>   ql/src/test/queries/clientpositive/index_auto_self_join.q PRE-CREATION 
>   ql/src/test/results/clientpositive/index_auto_mult_tables.q.out 
> PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/MapredWork.java a03a9a6 
>   ql/src/test/queries/clientpositive/index_auto_mult_tables.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/index_auto_mult_tables_compact.q 
> PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/index/HiveIndexResult.java b9b586e 
>   ql/src/java/org/apache/hadoop/hive/ql/index/HiveIndexedInputFormat.java 
> f1ee95d 
>   ql/src/java/org/apache/hadoop/hive/ql/index/bitmap/BitmapIndexHandler.java 
> 61bbbf5 
>   
> ql/src/java/org/apache/hadoop/hive/ql/index/compact/CompactIndexHandler.java 
> 7c91946 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/index/IndexWhereProcessor.java
>  dbc489f 
>   ql/src/java/org/apache/hadoop/hive/ql/index/HiveIndexQueryContext.java 
> 617723e 
> 
> Diff: https://reviews.apache.org/r/1010/diff
> 
> 
> Testing
> -------
> 
> added new testcase index_auto_mult_tables.q
> 
> 
> Thanks,
> 
> Syed
> 
>

Reply via email to