[ https://issues.apache.org/jira/browse/HIVE-2183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13072639#comment-13072639 ]
John Sichi commented on HIVE-2183: ---------------------------------- +1. Will commit when tests pass. > In Task class and its subclasses logger is initialized in constructor > --------------------------------------------------------------------- > > Key: HIVE-2183 > URL: https://issues.apache.org/jira/browse/HIVE-2183 > Project: Hive > Issue Type: Bug > Components: Query Processor > Affects Versions: 0.5.0, 0.8.0 > Environment: Hadoop 0.20.1, Hive0.8.0 and SUSE Linux Enterprise > Server 10 SP2 (i586) - Kernel 2.6.16.60-0.21-smp (5) > Reporter: Chinna Rao Lalam > Assignee: Chinna Rao Lalam > Priority: Minor > Attachments: HIVE-2183.1.patch, HIVE-2183.2.patch, HIVE-2183.patch > > > In Task class and its subclasses logger is initialized in constructor. Log > object no need to initialize every time in the constructor, Log object can > make it as static object. > {noformat} > Ex: > public ExecDriver() { > super(); > LOG = LogFactory.getLog(this.getClass().getName()); > console = new LogHelper(LOG); > this.jobExecHelper = new HadoopJobExecHelper(job, console, this, this); > } > {noformat} > Need to change like this > {noformat} > private static final Log LOG = LogFactory.getLog(ExecDriver.class); > {noformat} -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira