[ 
https://issues.apache.org/jira/browse/HIVE-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13079135#comment-13079135
 ] 

John Sichi commented on HIVE-2171:
----------------------------------

* Yes, please update RB
* checkstyle:  yeah, I think what people do is intersect the list of files they 
changed with the report output
* test suite:  yes, committers run the full suite and reject if anything fails, 
but it's best if authors do too (takes hours these days, so kick it off before 
you go to bed)

(And yes, we have ideas for improving all three of these inefficiencies, but so 
far no owners.)

> Allow custom serdes to set field comments
> -----------------------------------------
>
>                 Key: HIVE-2171
>                 URL: https://issues.apache.org/jira/browse/HIVE-2171
>             Project: Hive
>          Issue Type: Improvement
>    Affects Versions: 0.7.0
>            Reporter: Jakob Homan
>            Assignee: Jakob Homan
>         Attachments: HIVE-2171-2.patch, HIVE-2171.patch
>
>
> Currently, while serde implementations can set a field's name, they can't set 
> its comment.  These are set in the metastore utils to {{(from 
> deserializer)}}.  For those serdes that can provide meaningful comments for a 
> field, they should be propagated to the table description.  These 
> serde-provided comments could be prepended to "(from deserializer)" if others 
> feel that's a meaningful distinction.  This change involves updating 
> {{StructField}} to support a (possibly null) comment field and then 
> propagating this change out to the myriad places {{StructField}} is thrown 
> around.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to