[ https://issues.apache.org/jira/browse/HIVE-2334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13080217#comment-13080217 ]
jirapos...@reviews.apache.org commented on HIVE-2334: ----------------------------------------------------- bq. On 2011-08-05 20:38:11, Carl Steinbach wrote: bq. > cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java, line 235 bq. > <https://reviews.apache.org/r/1300/diff/1/?file=30859#file30859line235> bq. > bq. > Might want to consider using StringTokenizer or StreamTokenizer here. This is how it was in the original code. All of this can actually be done quite a bit better. I'm happy to switch to tokenizer; the patch is a bit schizophrenic about refactoring/improving. I didn't change this since it's not directly related to what I was trying to test. bq. On 2011-08-05 20:38:11, Carl Steinbach wrote: bq. > cli/src/test/org/apache/hadoop/hive/cli/TestCliDriverMethods.java, line 37 bq. > <https://reviews.apache.org/r/1300/diff/1/?file=30860#file30860line37> bq. > bq. > There's already some very limited test coverage for the hive.cli.print.header feature in print_header.q. Why not extend this testcase instead of adding a new unit test? Because this is an actual unit test against a specific regression, which has value separate from the print_header.q integration test. I can add additional content to print_header.q, since this test is easier to identify what's gone wrong and runs in about 0.2 seconds, this one seems more useful. bq. On 2011-08-05 20:38:11, Carl Steinbach wrote: bq. > ivy/libraries.properties, line 47 bq. > <https://reviews.apache.org/r/1300/diff/1/?file=30861#file30861line47> bq. > bq. > We need to manage this dependency with Ivy. The Hive build currently runs against hadoop-0.20.1, which does not include mockito-all-1.8.2.jar I'm sorry; I don't understand. This is being brought in by Ivy? As part of HIVE-2171, I had mentioned we need to make sure testing related jars don't get included during binary/package, but that should be done in a different JIRA. bq. On 2011-08-05 20:38:11, Carl Steinbach wrote: bq. > cli/src/test/org/apache/hadoop/hive/cli/TestCliDriverMethods.java, line 1 bq. > <https://reviews.apache.org/r/1300/diff/1/?file=30860#file30860line1> bq. > bq. > cli/build.xml overrides the ant test target with a no-op, so this test is actually not getting run. I'll update cli/build.xml to not be a no-op, unless there's some reason to? - Jakob ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1300/#review1308 ----------------------------------------------------------- On 2011-08-05 01:22:01, Jakob Homan wrote: bq. bq. ----------------------------------------------------------- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/1300/ bq. ----------------------------------------------------------- bq. bq. (Updated 2011-08-05 01:22:01) bq. bq. bq. Review request for hive. bq. bq. bq. Summary bq. ------- bq. bq. Commands that don't return a schema cause NPE when print headers is on. bq. bq. bq. This addresses bug HIVE-2334. bq. https://issues.apache.org/jira/browse/HIVE-2334 bq. bq. bq. Diffs bq. ----- bq. bq. cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 9fa7bc6 bq. cli/src/test/org/apache/hadoop/hive/cli/TestCliDriverMethods.java PRE-CREATION bq. ivy/libraries.properties af856bd bq. bq. Diff: https://reviews.apache.org/r/1300/diff bq. bq. bq. Testing bq. ------- bq. bq. New unit tests (both positive and negative) and verification on manual cluster. bq. bq. bq. Thanks, bq. bq. Jakob bq. bq. > DESCRIBE TABLE causes NPE when hive.cli.print.header=true > --------------------------------------------------------- > > Key: HIVE-2334 > URL: https://issues.apache.org/jira/browse/HIVE-2334 > Project: Hive > Issue Type: Bug > Components: CLI > Affects Versions: 0.7.1 > Reporter: Carl Steinbach > Assignee: Jakob Homan > Attachments: h2334.patch > > -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira