[ 
https://issues.apache.org/jira/browse/HIVE-2412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13098750#comment-13098750
 ] 

jirapos...@reviews.apache.org commented on HIVE-2412:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1665/#review1782
-----------------------------------------------------------

Ship it!


+1

- Amareshwari


On 2011-08-26 02:12:54, Carl Steinbach wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/1665/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-08-26 02:12:54)
bq.  
bq.  
bq.  Review request for hive and Amareshwari Sriramadasu.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  This patch does two things:
bq.  
bq.  * Fixes the eclipse project generation code by including mockito
bq.    on the classpath
bq.  
bq.  * Updates the HiveCli launch configuration template so that the
bq.    metastore JAR is no longer on the classpath, and also moves the
bq.    hive-exec JAR to the end of the classpath. This was done in
bq.    order to give preference on the classpath to local changes,
bq.    which up to this point have been obscured by hive-exec and
bq.    hive-metastore JAR files located in the build directory. Note
bq.    that in order to run the HiveCLI launchtemplate you now need to
bq.    have the Datanucleus Eclipse Plugin installed, and
bq.    must "enhance" the project.
bq.  
bq.  
bq.  This addresses bug HIVE-2412.
bq.      https://issues.apache.org/jira/browse/HIVE-2412
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    eclipse-templates/.classpath b59b343 
bq.    eclipse-templates/HiveCLI.launchtemplate 0fa86cb 
bq.  
bq.  Diff: https://reviews.apache.org/r/1665/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Verified that project generation and import works. Also verified that 
HiveCLI launch template works.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Carl
bq.  
bq.



> Update Eclipse configuration to include Mockito dependency
> ----------------------------------------------------------
>
>                 Key: HIVE-2412
>                 URL: https://issues.apache.org/jira/browse/HIVE-2412
>             Project: Hive
>          Issue Type: Bug
>          Components: Build Infrastructure
>            Reporter: Carl Steinbach
>            Assignee: Carl Steinbach
>             Fix For: 0.9.0
>
>         Attachments: HIVE-2412.1.patch.txt
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to