----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28699/#review63852 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkTask.java <https://reviews.apache.org/r/28699/#comment106158> Name this variable as "partitions" might be a little confusing. Same as below "partition". Maybe we can call them as partitionSpecs and partitionSpec respectively. ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkTask.java <https://reviews.apache.org/r/28699/#comment106159> "list" seems too general to be meaningful. - Xuefu Zhang On Dec. 4, 2014, 9:22 a.m., chengxiang li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28699/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2014, 9:22 a.m.) > > > Review request for hive and Xuefu Zhang. > > > Bugs: HIVE-8783 > https://issues.apache.org/jira/browse/HIVE-8783 > > > Repository: hive-git > > > Description > ------- > > Hive already has stats_counter.q and stats_counter_partitioned.q for unit > test of table statistic collection on Counter. stats_counter.q has enabled > yet, I enable stats_counter_partitioned.q in this patch. > > > Diffs > ----- > > itests/src/test/resources/testconfiguration.properties 09c667e > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkTask.java 30b7632 > ql/src/test/results/clientpositive/spark/stats_counter_partitioned.q.out > PRE-CREATION > > Diff: https://reviews.apache.org/r/28699/diff/ > > > Testing > ------- > > > Thanks, > > chengxiang li > >
