[ 
https://issues.apache.org/jira/browse/HIVE-198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13105680#comment-13105680
 ] 

John Sichi commented on HIVE-198:
---------------------------------

The updated patch does not apply cleanly.

Also, I tried the original test query from the description.

Before your patch, the message is "cannot recognize input near ',' 'bigint' ')' 
in column type".

After your patch, the message is "unexpected input token 'userid' near ',' 
'bigint' ')' in column type".

It's not clear that this is an improvement, since userid is fine; the syntax 
error is in what follows it.

The problem as originally reported (referring to KW_TEMPORARY) seems to have 
been fixed long ago.


> Parse errors report incorrectly.
> --------------------------------
>
>                 Key: HIVE-198
>                 URL: https://issues.apache.org/jira/browse/HIVE-198
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: S. Alex Smith
>            Assignee: Aviv Eyal
>              Labels: parse
>         Attachments: HIVE-198.2.patch.txt, PraseErrorMessage.patch
>
>
> The following two queries fail:
> CREATE TABLE output_table(userid, bigint);
> CREATE TABLE output_table(userid bigint, age int, sex string, location 
> string);
> each giving the error message "FAILED: Parse Error: line 1:16 mismatched 
> input 'TABLE' expecting KW_TEMPORARY"
> Although one might not catch it from the error message, the problem with the 
> first is that there is a comma between "userid" and "bigint", and the problem 
> with the second is that "location" is a reserved keyword.  Reported errors 
> should more accurately describe the nature of the error, such as "no type 
> given for column 'userid'" or "'location' is not a valid column name".

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to