> On Dec. 5, 2014, 2:27 a.m., Chao Sun wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SparkMapJoinResolver.java, > > line 96 > > <https://reviews.apache.org/r/28727/diff/1/?file=782893#file782893line96> > > > > I'm wondering if we can get rid of containsOp, and replace with this > > one. > > Jimmy Xiang wrote: > containsOp is used in many places. It's better to keep it. I changed > getOp a little so that getOp and containsOp share the same logic.
Sounds good. - Chao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28727/#review63952 ----------------------------------------------------------- On Dec. 4, 2014, 11:38 p.m., Jimmy Xiang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28727/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2014, 11:38 p.m.) > > > Review request for hive and Xuefu Zhang. > > > Bugs: HIVE-8638 > https://issues.apache.org/jira/browse/HIVE-8638 > > > Repository: hive-git > > > Description > ------- > > Patch v3 that works when bucket number matches > > > Diffs > ----- > > itests/src/test/resources/testconfiguration.properties 09c667e > ql/src/java/org/apache/hadoop/hive/ql/exec/SparkHashTableSinkOperator.java > cfc1501 > > ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinTableContainerSerDe.java > 2f9e55a > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SparkMapJoinResolver.java > 4054173 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkBucketJoinProcCtx.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkMapJoinOptimizer.java > 8b78123 > ql/src/test/queries/clientpositive/bucket_map_join_spark1.q PRE-CREATION > ql/src/test/queries/clientpositive/bucket_map_join_spark2.q PRE-CREATION > ql/src/test/results/clientpositive/bucket_map_join_spark1.q.out > PRE-CREATION > ql/src/test/results/clientpositive/bucket_map_join_spark2.q.out > PRE-CREATION > ql/src/test/results/clientpositive/spark/bucket_map_join_spark1.q.out > PRE-CREATION > ql/src/test/results/clientpositive/spark/bucket_map_join_spark2.q.out > PRE-CREATION > > Diff: https://reviews.apache.org/r/28727/diff/ > > > Testing > ------- > > > Thanks, > > Jimmy Xiang > >
