> On Dec. 8, 2014, 5:27 p.m., Chao Sun wrote: > > Hi, [~tedxu], thanks for the quick work! I just have one minor question: do > > you think it would be good to have a new test case for this? Maybe someone > > that just like join38.q, but uses common join and set number of reducers to > > be a number greater than one? > > Ashutosh Chauhan wrote: > yeah.. I think its a good idea to add testcase for this which reproduces > the bug. [~tedxu] For having more than 1 reducer in tests, you need to run > it through TestMinimrCliDriver. To achieve that, add name of your new test in > itests/src/test/resources/testconfiguration.properties > > Ted Xu wrote: > Will do, thank you guys for the advice! > > PS: I still got a -1 from Hadoop QA because of some UT failures, however, > I can't reproduce any of them on my laptop. Is there anything I'm doing wrong?
Make sure you are using TestMiniTezCliDriver for those reported failures, not TestCliDriver. If you still cant reproduce them, than don't bother about those. They are just .q.out golden files update. I can take care of those while comitting the patch. - Ashutosh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28791/#review64242 ----------------------------------------------------------- On Dec. 7, 2014, 9:30 a.m., Ted Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28791/ > ----------------------------------------------------------- > > (Updated Dec. 7, 2014, 9:30 a.m.) > > > Review request for hive, Ashutosh Chauhan and Chao Sun. > > > Bugs: HIVE-9025 > https://issues.apache.org/jira/browse/HIVE-9025 > > > Repository: hive > > > Description > ------- > > HIVE-5771 introduced a bug that when all partition columns are constants, the > partition is transformed to be a random dispatch, which is not expected. > > This patch adds a constant column in the above case to avoid random > partitioning. > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagateProcFactory.java > 1643530 > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/cluster.q.out > 1643530 > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/constprog2.q.out > 1643530 > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/join_nullsafe.q.out > 1643530 > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/ppd2.q.out > 1643530 > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/ppd_clusterby.q.out > 1643530 > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/ppd_join4.q.out > 1643530 > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/ppd_outer_join5.q.out > 1643530 > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/quotedid_basic.q.out > 1643530 > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/smb_mapjoin_25.q.out > 1643530 > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/union27.q.out > 1643530 > > Diff: https://reviews.apache.org/r/28791/diff/ > > > Testing > ------- > > TestCliDriver passed. > > > Thanks, > > Ted Xu > >
