-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29051/
-----------------------------------------------------------
Review request for hive and Brock Noland.
Bugs: HIVE-9091
https://issues.apache.org/jira/browse/HIVE-9091
Repository: hive-git
Description
-------
Change the function scope for the functions in HiveSQLException to be private,
including
toString(Throwable cause, StackTraceElement[] parent) ,
enroll(Throwable ex, StackTraceElement[] trace, int max),
toStackTrace(List<String> details, StackTraceElement[] parent, int index)
since these serve as helper function internally.
Add comments for the public functions in HiveSQLException.
To add additional unit test cases for HiveSQLException such as exception with
unknown source, test TStatus conversion, etc.
Diffs
-----
service/src/java/org/apache/hive/service/cli/HiveSQLException.java
c72cba3fa00847be321bd737fe8c2b79b3dab250
service/src/test/org/apache/hive/service/cli/TestHiveSQLException.java
586f5958063a34ba33ad05e44a27793983597353
Diff: https://reviews.apache.org/r/29051/diff/
Testing
-------
Testing is done in https://issues.apache.org/jira/browse/HIVE-9091 with one Tez
failure
(org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_optimize_nullscan).
Seems not related to my change.
Thanks,
Aihua Xu
