----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1978/ -----------------------------------------------------------
(Updated 2011-09-21 13:36:23.594198) Review request for hive, Carl Steinbach and John Sichi. Changes ------- Thrift generated code changes are excluded from the patch. Thrift generated code changes i will follow up. Summary ------- Fixed Log related Check style Comments like including root exception and adding messages. This addresses bug HIVE-2178. https://issues.apache.org/jira/browse/HIVE-2178 Diffs (updated) ----- trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveConnection.java 1173507 trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveDataSource.java 1173507 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1173507 trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Partition.java 1173507 trunk/ql/src/test/results/clientnegative/describe_xpath1.q.out 1173507 trunk/ql/src/test/results/clientnegative/describe_xpath2.q.out 1173507 trunk/ql/src/test/results/clientnegative/describe_xpath3.q.out 1173507 trunk/ql/src/test/results/clientnegative/describe_xpath4.q.out 1173507 trunk/ql/src/test/results/clientnegative/lockneg4.q.out 1173507 trunk/ql/src/test/results/clientnegative/lockneg5.q.out 1173507 trunk/serde/src/java/org/apache/hadoop/hive/serde2/dynamic_type/SimpleCharStream.java 1173507 trunk/serde/src/java/org/apache/hadoop/hive/serde2/thrift/TBinarySortableProtocol.java 1173507 Diff: https://reviews.apache.org/r/1978/diff Testing ------- Ran all unit tests Thanks, chinna