[ https://issues.apache.org/jira/browse/HIVE-2178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13109501#comment-13109501 ]
jirapos...@reviews.apache.org commented on HIVE-2178: ----------------------------------------------------- bq. On 2011-09-20 18:12:16, Ashutosh Chauhan wrote: bq. > trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/MetaException.java, lines 118-121 bq. > <https://reviews.apache.org/r/1978/diff/1/?file=43792#file43792line118> bq. > bq. > Same as above. Thrift generated code changes are excluded from the patch. Thrift generated code changes i will follow up. - chinna ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1978/#review1975 ----------------------------------------------------------- On 2011-09-21 13:36:23, chinna wrote: bq. bq. ----------------------------------------------------------- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/1978/ bq. ----------------------------------------------------------- bq. bq. (Updated 2011-09-21 13:36:23) bq. bq. bq. Review request for hive, Carl Steinbach and John Sichi. bq. bq. bq. Summary bq. ------- bq. bq. Fixed Log related Check style Comments like including root exception and adding messages. bq. bq. bq. This addresses bug HIVE-2178. bq. https://issues.apache.org/jira/browse/HIVE-2178 bq. bq. bq. Diffs bq. ----- bq. bq. trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveConnection.java 1173507 bq. trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveDataSource.java 1173507 bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1173507 bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Partition.java 1173507 bq. trunk/ql/src/test/results/clientnegative/describe_xpath1.q.out 1173507 bq. trunk/ql/src/test/results/clientnegative/describe_xpath2.q.out 1173507 bq. trunk/ql/src/test/results/clientnegative/describe_xpath3.q.out 1173507 bq. trunk/ql/src/test/results/clientnegative/describe_xpath4.q.out 1173507 bq. trunk/ql/src/test/results/clientnegative/lockneg4.q.out 1173507 bq. trunk/ql/src/test/results/clientnegative/lockneg5.q.out 1173507 bq. trunk/serde/src/java/org/apache/hadoop/hive/serde2/dynamic_type/SimpleCharStream.java 1173507 bq. trunk/serde/src/java/org/apache/hadoop/hive/serde2/thrift/TBinarySortableProtocol.java 1173507 bq. bq. Diff: https://reviews.apache.org/r/1978/diff bq. bq. bq. Testing bq. ------- bq. bq. Ran all unit tests bq. bq. bq. Thanks, bq. bq. chinna bq. bq. > Log related Check style Comments fixes > -------------------------------------- > > Key: HIVE-2178 > URL: https://issues.apache.org/jira/browse/HIVE-2178 > Project: Hive > Issue Type: Bug > Components: Query Processor > Affects Versions: 0.5.0, 0.8.0 > Environment: Hadoop 0.20.1, Hive0.8.0 and SUSE Linux Enterprise > Server 10 SP2 (i586) - Kernel 2.6.16.60-0.21-smp (5) > Reporter: Chinna Rao Lalam > Assignee: Chinna Rao Lalam > Attachments: HIVE-2178.1.patch, HIVE-2178.2.patch, HIVE-2178.3.patch, > HIVE-2178.patch > > > Fix Log related Check style Comments -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira