[ 
https://issues.apache.org/jira/browse/HIVE-9074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14250345#comment-14250345
 ] 

Ashutosh Chauhan commented on HIVE-9074:
----------------------------------------

Couple of comments:
* You can use validator in HiveConf via ConfVars(String varname, Object 
defaultVal, Validator validator, String description) constructor to force 
allowed values for a particular config.  This will allow you to get rid of 
{{isConfigEnabled}} variable and thus simplify a logic bit there.
* This throws exception as soon as datastore is found to be incompatible. If 
direct sql query is indeed fired but than fails while executing against 
datastore, we still catch that exception and than falls back to ORM. This patch 
is not intended to capture that code path, is it?

> add ability to force direct sql usage for perf reasons
> ------------------------------------------------------
>
>                 Key: HIVE-9074
>                 URL: https://issues.apache.org/jira/browse/HIVE-9074
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Sergey Shelukhin
>         Attachments: HIVE-9074.patch
>
>
> Some people run direct SQL and hit failures (e.g. due to Oracle 
> 1000-in-expressions stupidity, illegal cast "optimization" in Derby and 
> Oracle, or some other Hive and DB bugs). Currently, it falls back to ORM for 
> such cases, however that can have huge impact on perf, and some people would 
> rather have it fail so they can see the problem.
> In addition to "off" and "on+fallback" modes, "on or fail" mode needs to be 
> added. The default will remain the same.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to