[
https://issues.apache.org/jira/browse/HIVE-9004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14253857#comment-14253857
]
Thejas M Nair commented on HIVE-9004:
-------------------------------------
Yes, I agree this is not very intrusive behavior change, not many users are
likely to see issues because of this. I think documenting it should be OK.
However, some comments regarding the patch -
1. I think we should include a unit test for this.
2. I don't think the change would work. The properties object returned is a
copy, it won't update the HiveConf -
In HiveConf.java -
{code}
public Properties getAllProperties() {
return getProperties(this);
}
private static Properties getProperties(Configuration conf) {
Iterator<Map.Entry<String, String>> iter = conf.iterator();
Properties p = new Properties();
while (iter.hasNext()) {
Map.Entry<String, String> e = iter.next();
p.setProperty(e.getKey(), e.getValue());
}
return p;
}
{code}
> Reset doesn't work for the default empty value entry
> ----------------------------------------------------
>
> Key: HIVE-9004
> URL: https://issues.apache.org/jira/browse/HIVE-9004
> Project: Hive
> Issue Type: Bug
> Components: Configuration
> Reporter: Cheng Hao
> Assignee: Cheng Hao
> Fix For: spark-branch, 0.15.0, 0.14.1
>
> Attachments: HIVE-9004.patch
>
>
> To illustrate that:
> In hive cli:
> hive> set hive.table.parameters.default;
> hive.table.parameters.default is undefined
> hive> set hive.table.parameters.default=key1=value1;
> hive> reset;
> hive> set hive.table.parameters.default;
> hive.table.parameters.default=key1=value1
> I think we expect the last output as "hive.table.parameters.default is
> undefined"
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
