[ https://issues.apache.org/jira/browse/HIVE-9181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14256065#comment-14256065 ]
Szehon Ho commented on HIVE-9181: --------------------------------- +1 Looks good to me, thanks for the tough work. > Fix SkewJoinOptimizer related Java 8 ordering differences > --------------------------------------------------------- > > Key: HIVE-9181 > URL: https://issues.apache.org/jira/browse/HIVE-9181 > Project: Hive > Issue Type: Sub-task > Components: Tests > Reporter: Mohit Sabharwal > Assignee: Mohit Sabharwal > Attachments: HIVE-9181.1.patch, HIVE-9181.patch, HIVE-9181.patch > > > (1) {{SkewJoinOptimizer}} adds items to {{ParseContext.topOps}} is different > order in Java 8 vs Java 7. This leads to differences in EXPLAIN output > related to {{MapWork}}. > (2) Dbproperties order for a "desc database" query is non-deterministic at > the HiveMetastore end between Java 8 and Java 7 (because Thrift maps are > un-ordered). > {code} > create database test_db with dbproperties ('key1' = 'value1', 'key2' = > 'value2'); > desc database extended test_db; > {code} > At client side, we serialize the dbproperties map returned from HMS as string > and write it to a temp file. The {{FetchTask}} then reads the temp file and > returns the string back to the user. In test environment, for consistent > ordering, we should sort the map before it is serialized to the temp file. > -- This message was sent by Atlassian JIRA (v6.3.4#6332)