> On 2011-09-21 00:26:28, Carl Steinbach wrote: > > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java, line 892 > > <https://reviews.apache.org/r/1989/diff/1/?file=44442#file44442line892> > > > > Please add this configuration property to HiveConf and hive-default.xml > > Tom White wrote: > Does Hive have the concept of private configuration properties? This is > one that would set by SerDe's, not by users, which is why I didn't add it to > HiveConf/hive-default.xml. > > Carl Steinbach wrote: > No, it doesn't, but it should. I'll file a JIRA. In the meantime this > property should still be included in hive-default and HiveConf.
OK, I added the property to hive-default and HiveConf in the latest patch. - Tom ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1989/#review1982 ----------------------------------------------------------- On 2011-09-20 22:28:53, Carl Steinbach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1989/ > ----------------------------------------------------------- > > (Updated 2011-09-20 22:28:53) > > > Review request for hive. > > > Summary > ------- > > Review for HIVE-2457 > > > This addresses bug HIVE-2457. > https://issues.apache.org/jira/browse/HIVE-2457 > > > Diffs > ----- > > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java > 1173340 > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1173340 > trunk/ql/src/java/org/apache/hadoop/hive/ql/io/HiveFileFormatUtils.java > 1173340 > trunk/ql/src/test/org/apache/hadoop/hive/ql/exec/TestUtilities.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/1989/diff > > > Testing > ------- > > > Thanks, > > Carl > >
