[
https://issues.apache.org/jira/browse/HIVE-2450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113857#comment-13113857
]
jirapos...@reviews.apache.org commented on HIVE-2450:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1950/#review2061
-----------------------------------------------------------
Could you explain why we want the retry logic down inside of the
zookeeper-specific implementation? It seems to me that having it outside is
better, since then it doesn't have to be reimplemented in other lock manager
implementations as they are added.
trunk/ql/src/java/org/apache/hadoop/hive/ql/lockmgr/zookeeper/ZooKeeperHiveLockManager.java
<https://reviews.apache.org/r/1950/#comment4643>
quorumServers is not used by this method...why has it been added here?
trunk/ql/src/java/org/apache/hadoop/hive/ql/lockmgr/zookeeper/ZooKeeperHiveLockManager.java
<https://reviews.apache.org/r/1950/#comment4642>
But don't we still want to rethrow eventually out of this method? Here you
are squelching the exception completely.
- John
On 2011-09-23 21:10:26, Yongqiang He wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1950/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-23 21:10:26)
bq.
bq.
bq. Review request for hive and Ning Zhang.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. move lock retry logic into ZooKeeperHiveLockManager
bq.
bq.
bq. This addresses bug HIVE-2450.
bq. https://issues.apache.org/jira/browse/HIVE-2450
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1171255
bq. trunk/conf/hive-default.xml 1171255
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java 1171255
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveLockObject.java
1171255
bq.
trunk/ql/src/java/org/apache/hadoop/hive/ql/lockmgr/zookeeper/ZooKeeperHiveLockManager.java
1171255
bq.
bq. Diff: https://reviews.apache.org/r/1950/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. will run tests locally
bq.
bq.
bq. Thanks,
bq.
bq. Yongqiang
bq.
bq.
> move lock retry logic into ZooKeeperHiveLockManager
> ---------------------------------------------------
>
> Key: HIVE-2450
> URL: https://issues.apache.org/jira/browse/HIVE-2450
> Project: Hive
> Issue Type: Improvement
> Reporter: He Yongqiang
> Assignee: He Yongqiang
> Attachments: HIVE-2450.1.patch, HIVE-2450.2.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
