----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29382/#review66037 -----------------------------------------------------------
Ship it! Ship It! - Brock Noland On Dec. 24, 2014, 12:45 a.m., Mohit Sabharwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29382/ > ----------------------------------------------------------- > > (Updated Dec. 24, 2014, 12:45 a.m.) > > > Review request for hive. > > > Bugs: HIVE-9206 > https://issues.apache.org/jira/browse/HIVE-9206 > > > Repository: hive-git > > > Description > ------- > > HIVE-9206 : Fix Desc Formatted related Java 8 ordering differences > > This patch fixes the following tests for Java 8: > (1) list_bucket_dml_*.q > DESC FORMATTED calls StorageDescriptor.getSkewedInfo() HMS API, which returns > a thrift (unordered) map. Generate java version specific out file for these > tests. > > (2) partitions_json.q > SHOW PARTITIONS uses MapBuilder via JsonMetaDataFormatter which uses HashMap. > Changed it to ordered map. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MapBuilder.java > 16e1c04883f7282b08cefe1d000cdaca1bd819d7 > ql/src/test/queries/clientpositive/list_bucket_dml_10.q > 2fbafc20169b5ea847f404362b1a686c82f98fa8 > ql/src/test/queries/clientpositive/list_bucket_dml_11.q > 8260459725efe9812c3cf2a5778db7c13b1c1c9f > ql/src/test/queries/clientpositive/list_bucket_dml_12.q > 0cab1492c5a1a634371e58ee8e9dadfc3f886e1f > ql/src/test/queries/clientpositive/list_bucket_dml_13.q > 5ea333fd40924bab0b08594d3fd5cf456b525f71 > ql/src/test/queries/clientpositive/list_bucket_dml_2.q > 9715ff6c19fcbf82e37eb71e273481d64590670f > ql/src/test/queries/clientpositive/list_bucket_dml_4.q > 1ca54fac79f623fc49152e85e1a573361ff8bed1 > ql/src/test/queries/clientpositive/list_bucket_dml_5.q > 5278a80891bb10b0360aa2ce8eeca9d7ade9ddb0 > ql/src/test/queries/clientpositive/list_bucket_dml_8.q > 26103f975307968a216d52276028747f86c89ef3 > ql/src/test/queries/clientpositive/list_bucket_dml_9.q > 4ddcdddf888cb76961341c10ea11dabf5f7c9dd7 > ql/src/test/queries/clientpositive/stats_list_bucket.q > 59826437415483d0f65f398342be965dd4d4938c > ql/src/test/results/clientpositive/list_bucket_dml_11.q.java1.7.out > PRE-CREATION > ql/src/test/results/clientpositive/list_bucket_dml_11.q.java1.8.out > PRE-CREATION > ql/src/test/results/clientpositive/list_bucket_dml_11.q.out > a6e6db374723d9187dabdb6122f144485d9a9658 > ql/src/test/results/clientpositive/list_bucket_dml_12.q.java1.7.out > PRE-CREATION > ql/src/test/results/clientpositive/list_bucket_dml_12.q.java1.8.out > PRE-CREATION > ql/src/test/results/clientpositive/list_bucket_dml_12.q.out > b14b4ec5a4a97bec1298b58c45bb867e5ee03493 > ql/src/test/results/clientpositive/list_bucket_dml_13.q.java1.7.out > PRE-CREATION > ql/src/test/results/clientpositive/list_bucket_dml_13.q.java1.8.out > PRE-CREATION > ql/src/test/results/clientpositive/list_bucket_dml_13.q.out > 6e3c20492ebd67622c7b8ebe8fbfdf08ed7b66b0 > ql/src/test/results/clientpositive/list_bucket_dml_2.q.java1.7.out > PRE-CREATION > ql/src/test/results/clientpositive/list_bucket_dml_2.q.java1.8.out > PRE-CREATION > ql/src/test/results/clientpositive/list_bucket_dml_2.q.out > 797cc5032d88a3cd441796b48caa729478d7d68c > ql/src/test/results/clientpositive/list_bucket_dml_4.q.java1.7.out > PRE-CREATION > ql/src/test/results/clientpositive/list_bucket_dml_4.q.java1.8.out > PRE-CREATION > ql/src/test/results/clientpositive/list_bucket_dml_4.q.out > 7800b539974d5f75c532050fa4f1e1c34b54628e > ql/src/test/results/clientpositive/list_bucket_dml_5.q.java1.7.out > PRE-CREATION > ql/src/test/results/clientpositive/list_bucket_dml_5.q.java1.8.out > PRE-CREATION > ql/src/test/results/clientpositive/list_bucket_dml_5.q.out > 5c413af5b1b0529b5bf54b4c5dc69fc5ad5afaa5 > ql/src/test/results/clientpositive/list_bucket_dml_8.q.java1.7.out > PRE-CREATION > ql/src/test/results/clientpositive/list_bucket_dml_8.q.java1.8.out > PRE-CREATION > ql/src/test/results/clientpositive/list_bucket_dml_8.q.out > bb685294d5cd361e058bb01d6db61cb9dac66974 > ql/src/test/results/clientpositive/list_bucket_dml_9.q.java1.7.out > PRE-CREATION > ql/src/test/results/clientpositive/list_bucket_dml_9.q.java1.8.out > PRE-CREATION > ql/src/test/results/clientpositive/list_bucket_dml_9.q.out > 3274d7445bdb81fec9d69efe479823a0c0e04fba > ql/src/test/results/clientpositive/partitions_json.q.out > e934f593911eb7fdc190c40d9eeff355822476eb > ql/src/test/results/clientpositive/stats_list_bucket.q.java1.7.out > PRE-CREATION > ql/src/test/results/clientpositive/stats_list_bucket.q.java1.8.out > PRE-CREATION > ql/src/test/results/clientpositive/stats_list_bucket.q.out > 8f68e8b607b0a89ceaf9a7e83af54b197c76597d > > Diff: https://reviews.apache.org/r/29382/diff/ > > > Testing > ------- > > Tests pass on Java 8 and Java 7 > > > Thanks, > > Mohit Sabharwal > >
