[ https://issues.apache.org/jira/browse/HIVE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115583#comment-13115583 ]
jirapos...@reviews.apache.org commented on HIVE-2196: ----------------------------------------------------- ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1423/ ----------------------------------------------------------- (Updated 2011-09-27 15:51:37.029125) Review request for hive, Carl Steinbach and John Sichi. Changes ------- All tests passed Summary ------- The below configurations are not used in the code base so removed from the hive-default.xml hive.mapjoin.hashtable.initialCapacity hive.mapjoin.hashtable.loadfactor hive.mapjoin.smalltable.filesize hive.optimize.pruner hive.stats.jdbc.atomic hive.concurrency.manager The below configurations are not used in the code base but these configurations are required for the system so need to maintain in the hive-default.xml and no need to add in the HiveConf.java javax.jdo.option.ConnectionDriverName javax.jdo.PersistenceManagerFactoryClass javax.jdo.option.DetachAllOnCommit javax.jdo.option.NonTransactionalRead javax.jdo.option.ConnectionUserName fs.har.impl This addresses bug HIVE-2196. https://issues.apache.org/jira/browse/HIVE-2196 Diffs (updated) ----- trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1175859 trunk/conf/hive-default.xml 1175859 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1175859 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1175859 trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMarkPartitionRemote.java 1175859 trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java 1175859 trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java 1175859 trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteHiveMetaStore.java 1175859 trunk/shims/src/test/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java 1175859 Diff: https://reviews.apache.org/r/1423/diff Testing ------- All unit tests passed Thanks, chinna > Ensure HiveConf includes all properties defined in hive-default.xml > ------------------------------------------------------------------- > > Key: HIVE-2196 > URL: https://issues.apache.org/jira/browse/HIVE-2196 > Project: Hive > Issue Type: Bug > Components: Configuration > Affects Versions: 0.8.0 > Reporter: Carl Steinbach > Assignee: Chinna Rao Lalam > Attachments: HIVE-2196.1.patch, HIVE-2196.2.patch, HIVE-2196.3.patch, > HIVE-2196.4.patch, HIVE-2196.build.log, HIVE-2196.patch > > > There are a bunch of properties that are defined in hive-default.xml but not > in HiveConf. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira