----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28941/ -----------------------------------------------------------
(Updated Jan. 5, 2015, 12:26 p.m.) Review request for hive, John Pullokkaran and Julian Hyde. Changes ------- Rebased patch. Added recognition of CUBE and ROLLUP in ASTConverter as suggested. Bugs: HIVE-8988 https://issues.apache.org/jira/browse/HIVE-8988 Repository: hive-git Description (updated) ------- HIVE-8988 HIVE-8988 HIVE-8988 Diffs (updated) ----- ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveGroupingID.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTConverter.java c02a65e2041e4742a56cf4a935da0a7c04d18fdb ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 5d72e150acd0f0848a62af98a6d26b7ece893fd2 ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java f18f8dbc1b9c4a1ae4fa3896ee5435a1e49fc54c ql/src/test/queries/clientpositive/groupby_cube1.q c12720b27059075050fc92d9f31420c081303699 ql/src/test/queries/clientpositive/groupby_grouping_sets6.q PRE-CREATION ql/src/test/results/clientpositive/annotate_stats_groupby.q.out 4f48aef2f7f6a809da6ba68d2d98afc312015baa ql/src/test/results/clientpositive/annotate_stats_groupby2.q.out bcc5745a8a6d5619f656ae3f858a5cd230d3d9c2 ql/src/test/results/clientpositive/groupby_cube1.q.out 7b5d70ae8ffce47a4b351ed9dfedcd15ab1e139c ql/src/test/results/clientpositive/groupby_grouping_sets2.q.out 7c88a67e377fe92cd4ecbd6e1ec12cd541d98bba ql/src/test/results/clientpositive/groupby_grouping_sets3.q.out 6ae6e551eb7646bc81d32f135c551ff68901d6e3 ql/src/test/results/clientpositive/groupby_grouping_sets5.q.out cf1515c129d7d8e945fbe7904e01710749220ef4 ql/src/test/results/clientpositive/groupby_grouping_sets6.q.out PRE-CREATION ql/src/test/results/clientpositive/groupby_rollup1.q.out bc77aeaf2a56561a03227ea47bd93ed93d95996e ql/src/test/results/clientpositive/infer_bucket_sort_grouping_operators.q.out 044946f4242599a3db3b7a7b5a2538d647370052 Diff: https://reviews.apache.org/r/28941/diff/ Testing ------- Thanks, Jesús Camacho Rodríguez