[ 
https://issues.apache.org/jira/browse/HIVE-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14264763#comment-14264763
 ] 

Sergio Peña commented on HIVE-9254:
-----------------------------------

Hi [~Ferd],

The changes look good. But our changes for running useful commands for testing 
in the future will work only for the encrypted framework. Is there a way to do 
these changes more generic for all kind of frameworks?

I was thinking we could revert the old getCommands() method, and make changes 
on the executeClient() method to loop into the returned string from 
getComands() but by spliting lines that end with ';'. This way we can check for 
the testing commands (only case so far is crypto).

What do you think?

> incompatible output format for prohook according to the encryption changes
> --------------------------------------------------------------------------
>
>                 Key: HIVE-9254
>                 URL: https://issues.apache.org/jira/browse/HIVE-9254
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Ferdinand Xu
>            Assignee: Ferdinand Xu
>             Fix For: encryption-branch
>
>         Attachments: HIVE-9254.patch
>
>
> Running: diff -a 
> /home/hiveptest/54.167.165.215-hiveptest-1/apache-svn-HIVE-8065-source/itests/qtest/../../itests/qtest/target/qfile-results/clientpositive/input32.q.out
>  
> /home/hiveptest/54.167.165.215-hiveptest-1/apache-svn-HIVE-8065-source/itests/qtest/../../ql/src/test/results/clientpositive/input32.q.out
> 17c17,19
> < PREHOOK: query: explain insert overwrite table dest32 select count(1) from 
> srcbucket
> ---
> > PREHOOK: query: explain 
> > insert overwrite table dest32
> > select count(1) from srcbucket
> 19c21,23
> < POSTHOOK: query: explain insert overwrite table dest32 select count(1) from 
> srcbucket
> ---
> > POSTHOOK: query: explain 
> > insert overwrite table dest32
> > select count(1) from srcbucket
> 76c80,81
> < PREHOOK: query: insert overwrite table dest32 select count(1) from srcbucket
> ---
> > PREHOOK: query: insert overwrite table dest32
> > select count(1) from srcbucket
> 80c85,86
> < POSTHOOK: query: insert overwrite table dest32 select count(1) from 
> srcbucket
> ---
> > POSTHOOK: query: insert overwrite table dest32
> > select count(1) from srcbucket



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to