[
https://issues.apache.org/jira/browse/HIVE-9183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14265006#comment-14265006
]
Sergey Shelukhin commented on HIVE-9183:
----------------------------------------
Nit: can be made final.
Also, this changes HBase dependency version in the POM. Is this intended, or
just for testing?
> Compilation against HBase 1.0.0 fails due to missing dependency on
> high_scale_lib.Counter
> -----------------------------------------------------------------------------------------
>
> Key: HIVE-9183
> URL: https://issues.apache.org/jira/browse/HIVE-9183
> Project: Hive
> Issue Type: Task
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: HIVE-9183-001.patch, HIVE-9183.patch
>
>
> In the HBase 1.0.0 release, org.cliffc.high_scale_lib is no longer used.
> HBaseStorageHandler.java has compile time dependency on high_scale_lib.Counter
> Compilation against HBase 1.0.0 release would fail due to the missing
> dependency.
> The following change would allow compilation to pass:
> {code}
> diff --git
> a/hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java
>
> b/hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java
> index 3218639..6f626f0 100644
> ---
> a/hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java
> +++
> b/hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java
> @@ -499,8 +499,8 @@ public void configureJobConf(TableDesc tableDesc, JobConf
> jobConf) {
> * only need TableMapReduceUtil.addDependencyJars(jobConf) here.
> */
> TableMapReduceUtil.addDependencyJars(
> - jobConf, HBaseStorageHandler.class, TableInputFormatBase.class,
> - org.cliffc.high_scale_lib.Counter.class); // this will be removed
> for HBase 1.0
> + jobConf, HBaseStorageHandler.class, TableInputFormatBase.class);
> + // org.cliffc.high_scale_lib.Counter.class); this will be removed
> for HBase 1.0
> Set<String> merged = new
> LinkedHashSet<String>(jobConf.getStringCollection("tmpjars"));
> Job copy = new Job(jobConf);
> {code}
> However, loading of high_scale_lib.Counter should be done at runtime so that
> 0.98 and 1.0 releases are both supported.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
