----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29702/#review67460 -----------------------------------------------------------
Ship it! Ship It! - Brock Noland On Jan. 8, 2015, 8:16 a.m., Mohit Sabharwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29702/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2015, 8:16 a.m.) > > > Review request for hive. > > > Bugs: HIVE-9309 > https://issues.apache.org/jira/browse/HIVE-9309 > > > Repository: hive-git > > > Description > ------- > > HIVE-9309 : schematool fails on Postgres 8.1 > > Postgres upgrade scripts set "standard_conforming_strings" which is not > allowed in 8.1: > ERROR: parameter "standard_conforming_strings" cannot be changed > (state=55P02,code=0) > > Postgres 8.1 Release notes say that "standard_conforming_strings value is > read-only" > Postgres 8.2 notes say that it can be set at runtime. > > It'd be nice to address this for those still using Postgres 8.1 > > This patch provides a schemaTool db option "postgres.filter.81" which, if > set, filters out the "standard_conforming_strings" statement from upgrade > scripts. > > > Diffs > ----- > > beeline/src/java/org/apache/hive/beeline/HiveSchemaHelper.java > d13d8b67d09704ac8575b8f8bc80192569b06aba > itests/hive-unit/src/test/java/org/apache/hive/beeline/TestSchemaTool.java > 9ae9bc0a267e41a852aa6f87bab532763f9c54b3 > > Diff: https://reviews.apache.org/r/29702/diff/ > > > Testing > ------- > > Added unit test > > > Thanks, > > Mohit Sabharwal > >
