[
https://issues.apache.org/jira/browse/HIVE-9335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14273094#comment-14273094
]
Hive QA commented on HIVE-9335:
-------------------------------
{color:red}Overall{color}: -1 at least one tests failed
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12691570/HIVE-9335.2-spark.patch
{color:red}ERROR:{color} -1 due to 6 failed/errored test(s), 7301 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_optimize_nullscan
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver_optimize_nullscan
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver_windowing
org.apache.hive.hcatalog.streaming.TestStreaming.testEndpointConnection
org.apache.hive.hcatalog.streaming.TestStreaming.testInterleavedTransactionBatchCommits
org.apache.hive.hcatalog.streaming.TestStreaming.testMultipleTransactionBatchCommits
{noformat}
Test results:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-SPARK-Build/631/testReport
Console output:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-SPARK-Build/631/console
Test logs:
http://ec2-50-18-27-0.us-west-1.compute.amazonaws.com/logs/PreCommit-HIVE-SPARK-Build-631/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 6 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12691570 - PreCommit-HIVE-SPARK-Build
> Address review items on HIVE-9257 [Spark Branch]
> ------------------------------------------------
>
> Key: HIVE-9335
> URL: https://issues.apache.org/jira/browse/HIVE-9335
> Project: Hive
> Issue Type: Sub-task
> Components: Spark
> Affects Versions: spark-branch
> Reporter: Brock Noland
> Assignee: Brock Noland
> Attachments: HIVE-9335.1-spark.patch, HIVE-9335.2-spark.patch
>
>
> I made a pass through HIVE-9257 and found the following issues:
> {{HashTableSinkOperator.java}}
> The fields EMPTY_OBJECT_ARRAY and EMPTY_ROW_CONTAINER are no longer constants
> and should not be in upper case.
> {{HivePairFlatMapFunction.java}}
> We share NumberFormat accross threads and it's not thread safe.
> {{KryoSerializer.java}}
> we eat the stack trace in deserializeJobConf
> {{SparkMapRecordHandler}}
> in processRow we should not be using {{StringUtils.stringifyException}} since
> LOG can handle stack traces.
> in close:
> {noformat}
> // signal new failure to map-reduce
> LOG.error("Hit error while closing operators - failing tree");
> throw new IllegalStateException("Error while closing operators", e);
> {noformat}
> Should be:
> {noformat}
> String msg = "Error while closing operators: " + e;
> throw new IllegalStateException(msg, e);
> {noformat}
> {{SparkSessionManagerImpl}} - the method {{canReuseSession}} is useless
> {{GenSparkSkewJoinProcessor}}
> {noformat}
> + // keep it as reference in case we need fetch work
> +// localPlan.getAliasToFetchWork().put(small_alias.toString(),
> +// new FetchWork(tblDir, tableDescList.get(small_alias)));
> {noformat}
> {{GenSparkWorkWalker}} trim ws
> {{SparkCompiler}} remote init
> {{SparkEdgeProperty}} trim ws
> {{CounterStatsPublisher}} eat exception
> {{Hadoop23Shims}} unused import of {{ResourceBundles}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
