> On Jan. 13, 2015, 6:47 a.m., chengxiang li wrote: > > spark-client/src/main/java/org/apache/hive/spark/client/SparkClient.java, > > line 55 > > <https://reviews.apache.org/r/29832/diff/1/?file=818434#file818434line55> > > > > In API level, it's still an asynchronous RPC API, as the use case of > > this API described in the javadoc, do you think it would be more clean to > > supply a synchronous API like: T run(Job<T> job)?
No. With a client-side synchronous API, it's awkward to specify things like timeouts - you either need explicit parameters which are not really part of the RPC, or extra configuration. Here, you just say `client.run().get(someTimeout)` if you want the call to be synchronous on the client side. - Marcelo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29832/#review67813 ----------------------------------------------------------- On Jan. 13, 2015, 12:31 a.m., Marcelo Vanzin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29832/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2015, 12:31 a.m.) > > > Review request for hive, Brock Noland, chengxiang li, and Xuefu Zhang. > > > Bugs: HIVE-9178 > https://issues.apache.org/jira/browse/HIVE-9178 > > > Repository: hive-git > > > Description > ------- > > HIVE-9178. Add a synchronous RPC API to the remote Spark context. > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/impl/RemoteSparkJobStatus.java > 5c3ca018bb177ef9fd9fb24b054a9db29274b31e > spark-client/src/main/java/org/apache/hive/spark/client/BaseProtocol.java > f9c10b196ab47b5b4f4c0126ad455869ab68f0ca > spark-client/src/main/java/org/apache/hive/spark/client/RemoteDriver.java > 0d49ed3d9e33ca08d6a7526c1c434a0dd0a06a67 > spark-client/src/main/java/org/apache/hive/spark/client/SparkClient.java > 5e767ef5eb47e493a332607204f4c522028d7d0e > > spark-client/src/main/java/org/apache/hive/spark/client/SparkClientImpl.java > f8b2202a465bb8abe3d2c34e49ade6387482738c > > Diff: https://reviews.apache.org/r/29832/diff/ > > > Testing > ------- > > > Thanks, > > Marcelo Vanzin > >
