[jira] [Commented] (HIVE-9364) Document non-Public API's which Spark SQL uses

[Marcelo Vanzin (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HIVE-9364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14276100#comment-14276100
 ] 

Marcelo Vanzin commented on HIVE-9364:
--------------------------------------

Here are three APIs that changed between 0.13 and trunk which are used by 
SparkSQL:

https://github.com/apache/hive/commit/cf7028289dbe39cdbda208286aa4b53086958a8e
{code}
// old
public boolean dropIndex(String baseTableName, String index_name, boolean 
deleteData) throws HiveException {
// new
public boolean dropIndex(String baseTableName, String index_name,
  boolean throwException, boolean deleteData) throws HiveException {
{code}

https://github.com/apache/hive/commit/29b88a117ca3900a83eaab44c74b27164493fc56
{code}
// old
public Path getExternalTmpPath(URI extURI) {
// new
public Path getExternalTmpPath(Path path) {
{code}

https://github.com/apache/hive/commit/9243cbbfe2f22b7ab0453d8766c6d5ae333be368

{code}
// old
public ArrayList<LinkedHashMap<String, String>> loadDynamicPartitions(Path 
loadPath,
  String tableName, Map<String, String> partSpec, boolean replace,
  int numDP, boolean holdDDLTime, boolean listBucketingEnabled, boolean isAcid)
  throws HiveException {
// new
public Map<Map<String, String>, Partition> loadDynamicPartitions(Path loadPath,
  String tableName, Map<String, String> partSpec, boolean replace,
  int numDP, boolean holdDDLTime, boolean listBucketingEnabled, boolean isAcid)
  throws HiveException {
{code}
{code}
// old
public void loadPartition(Path loadPath, String tableName,
  Map<String, String> partSpec, boolean replace, boolean holdDDLTime,
  boolean inheritTableSpecs, boolean isSkewedStoreAsSubdir,
  boolean isSrcLocal, boolean isAcid) throws HiveException {
// new
public Partition loadPartition(Path loadPath, Table tbl,
  Map<String, String> partSpec, boolean replace, boolean holdDDLTime,
  boolean inheritTableSpecs, boolean isSkewedStoreAsSubdir,
  boolean isSrcLocal, boolean isAcid) throws HiveException {
{code}

(For loadDynamicPartitions, there's an extra change, 
https://github.com/apache/hive/commit/2568066d, which added the "isAcid" 
argument.)

> Document non-Public API's which Spark SQL uses
> ----------------------------------------------
>
>                 Key: HIVE-9364
>                 URL: https://issues.apache.org/jira/browse/HIVE-9364
>             Project: Hive
>          Issue Type: Sub-task
>          Components: API
>            Reporter: Brock Noland
>             Fix For: 1.0.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)