[ https://issues.apache.org/jira/browse/HIVE-9253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14282791#comment-14282791 ]
Brock Noland commented on HIVE-9253: ------------------------------------ Hi Dong, Sorry for taking so long to review this! Looks like a great start! I don't understand why usage 1 doesn't work but if not, yes usage 2 is certainly fine. We could even add the start end calls to {{start*Function*}} and {{endFunction}} methods in {{HiveMetaStore}}. With regard to testing, I think we could add a static flag to {{HiveMetaStore}} called {{TESTING_TIMEOUT}} and then one of the methods if this flag is set, sleep for some period of time. Again, looks great and looking forward to seeing this implemented! Brock > MetaStore server should support timeout for long running requests > ----------------------------------------------------------------- > > Key: HIVE-9253 > URL: https://issues.apache.org/jira/browse/HIVE-9253 > Project: Hive > Issue Type: Sub-task > Components: Metastore > Reporter: Dong Chen > Assignee: Dong Chen > Attachments: HIVE-9253.1.patch, HIVE-9253.patch > > > In the description of HIVE-7195, one issue is that MetaStore client timeout > is quite dumb. The client will timeout and the server has no idea the client > is gone. > The server should support timeout when the request from client runs a long > time. -- This message was sent by Atlassian JIRA (v6.3.4#6332)