----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29961/#review68733 -----------------------------------------------------------
Hi Ferdinand! What license are the drivers under? We'll have to make sure they both fit under: http://www.apache.org/legal/resolved.html As opposed to that, I wonder if we can create some dummy class which is used to generate a Driver? Then you can passing a url like jdbc:mockdb:// and we don't have to ship a "real" jar? beeline/src/java/org/apache/hive/beeline/ClassNameCompleter.java <https://reviews.apache.org/r/29961/#comment113115> Add + e to end of string beeline/src/java/org/apache/hive/beeline/ClassNameCompleter.java <https://reviews.apache.org/r/29961/#comment113116> Add + e to end of string beeline/src/java/org/apache/hive/beeline/Commands.java <https://reviews.apache.org/r/29961/#comment113117> after this line we should add: beeLine.error(e); beeline/src/java/org/apache/hive/beeline/Commands.java <https://reviews.apache.org/r/29961/#comment113118> after this line we should add: beeLine.error(e); beeline/src/java/org/apache/hive/beeline/DatabaseConnection.java <https://reviews.apache.org/r/29961/#comment113119> after this line we should add: beeLine.error(e); beeline/src/java/org/apache/hive/beeline/DatabaseConnection.java <https://reviews.apache.org/r/29961/#comment113120> after this line we should add: beeLine.error(e); beeline/src/java/org/apache/hive/beeline/DatabaseConnection.java <https://reviews.apache.org/r/29961/#comment113121> after this line we should add: beeLine.error(e); beeline/src/java/org/apache/hive/beeline/DatabaseConnection.java <https://reviews.apache.org/r/29961/#comment113122> after this line we should add: beeLine.error(e); - Brock Noland On Jan. 16, 2015, 6:17 a.m., cheng xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29961/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2015, 6:17 a.m.) > > > Review request for hive, Brock Noland, Dong Chen, and Sergio Pena. > > > Repository: hive-git > > > Description > ------- > > Support adding local driver jar file in the beeline side and add unit test > for it > > > Diffs > ----- > > beeline/src/java/org/apache/hive/beeline/BeeLine.java 630ead4 > beeline/src/java/org/apache/hive/beeline/ClassNameCompleter.java 065eab4 > beeline/src/java/org/apache/hive/beeline/Commands.java 291adba > beeline/src/java/org/apache/hive/beeline/DatabaseConnection.java 8ba0232 > beeline/src/main/resources/BeeLine.properties d038d46 > beeline/src/test/org/apache/hive/beeline/TestBeelineArgParsing.java a6ee93a > beeline/src/test/resources/mysql-connector-java-bin.jar PRE-CREATION > beeline/src/test/resources/postgresql-9.3.jdbc3.jar PRE-CREATION > > Diff: https://reviews.apache.org/r/29961/diff/ > > > Testing > ------- > > Manullay test done. > Newly added test passed. > > > Thanks, > > cheng xu > >
