[
https://issues.apache.org/jira/browse/HIVE-9408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14284082#comment-14284082
]
Xuefu Zhang commented on HIVE-9408:
-----------------------------------
Patch looks good. However, I don't quite understand the following code snippet:
{code}
+ List<Redactor> queryRedactors = getHooks(ConfVars.QUERYREDACTORHOOKS,
Redactor.class);
+ for (Redactor redactor : queryRedactors) {
+ redactor.setConf(conf);
+ queryStr = redactor.redactQuery(queryStr);
+ }
{code}
it seems that queryStr is just overwritten over and over again in the loop.
> Add hook interface so queries can be redacted before being placed in job.xml
> ----------------------------------------------------------------------------
>
> Key: HIVE-9408
> URL: https://issues.apache.org/jira/browse/HIVE-9408
> Project: Hive
> Issue Type: Task
> Components: Query Processor
> Affects Versions: 0.15.0
> Reporter: Brock Noland
> Assignee: Brock Noland
> Attachments: HIVE-9408.1.patch, HIVE-9408.2.patch, HIVE-9408.3.patch
>
>
> Today we take a query and place it in the job.xml file which is pushed to all
> nodes the query runs on. However it's possible the query contains sensitive
> information and should not directly be shown to users.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
