[
https://issues.apache.org/jira/browse/HIVE-9378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14287946#comment-14287946
]
Xuefu Zhang commented on HIVE-9378:
-----------------------------------
Patch looks good. One thing though: using Assert.assertTrue() to break the
while loop seems a little abnormal and might make the code a little harder to
understand.
{code}
+ while (sparkSession.getMemoryAndCores().getSecond() <= 1) {
+ Assert.assertTrue("Timed out waiting for Spark cluster to init",
+ System.currentTimeMillis() < endTime);
+ Thread.sleep(100);
+ }
{code}
> Spark qfile tests should reuse RSC [Spark Branch]
> -------------------------------------------------
>
> Key: HIVE-9378
> URL: https://issues.apache.org/jira/browse/HIVE-9378
> Project: Hive
> Issue Type: Improvement
> Components: Spark
> Affects Versions: spark-branch
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Fix For: spark-branch
>
> Attachments: HIVE-9378.1-spark.patch, HIVE-9378.2-spark.patch
>
>
> Run several qfile tests, use jps to monitor the java processes. You will find
> several SparkSubmitDriverBootstrapper processes are created (not the same
> time of course). It seems to me that we create a RSC for each qfile, then
> terminate it when this qfile test is done. The RSC seems not shared among
> qfiles.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
