----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30107/#review69344 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java <https://reviews.apache.org/r/30107/#comment114027> Could we add a check, something like: if (hive.execution.engine=="spark") { try { ... } The code as it is might make other people frown. - Xuefu Zhang On Jan. 22, 2015, 9:23 a.m., chengxiang li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30107/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2015, 9:23 a.m.) > > > Review request for hive and Xuefu Zhang. > > > Bugs: HIVE-9410 > https://issues.apache.org/jira/browse/HIVE-9410 > > > Repository: hive-git > > > Description > ------- > > The RemoteDriver does not contains added jar in it's classpath, so it would > failed to desrialize SparkWork due to NoClassFoundException. For Hive on MR, > while use add jar through Hive CLI, Hive add jar into CLI classpath(through > thread context classloader) and add it to distributed cache as well. Compare > to Hive on MR, Hive on Spark has an extra RemoteDriver componnet, we should > add added jar into it's classpath as well. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java d7cb111 > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/RemoteHiveSparkClient.java > 30a00a7 > spark-client/src/main/java/org/apache/hive/spark/client/JobContext.java > 00aa4ec > spark-client/src/main/java/org/apache/hive/spark/client/JobContextImpl.java > 1eb3ff2 > > spark-client/src/main/java/org/apache/hive/spark/client/SparkClientImpl.java > 5f9be65 > > spark-client/src/main/java/org/apache/hive/spark/client/SparkClientUtilities.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/30107/diff/ > > > Testing > ------- > > > Thanks, > > chengxiang li > >