[
https://issues.apache.org/jira/browse/HIVE-9470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14292772#comment-14292772
]
Ferdinand Xu commented on HIVE-9470:
------------------------------------
LGTM with some minor suggestions.
{noformat}
131 public ColumnarStorageBench() {
{noformat}
Please remove extra space.
{noformat}
233 private ObjectInspector getParquetObjectInspector(final String
columnTypes) {
{noformat}
Can you rename it with getArrayWritableObjectInspector since it will be used by
both parquet and orc?
{noformat}
242 Writable parquetWritable =
createRecord(TypeInfoUtils.getTypeInfosFromTypeString(columnTypes));
{noformat}
Can you rename it with recordWritable for the same reason as above?
> Use a generic writable object to run ColumnaStorageBench write/read tests
> --------------------------------------------------------------------------
>
> Key: HIVE-9470
> URL: https://issues.apache.org/jira/browse/HIVE-9470
> Project: Hive
> Issue Type: Improvement
> Reporter: Sergio Peña
> Assignee: Sergio Peña
> Attachments: HIVE-9470.1.patch
>
>
> The ColumnarStorageBench benchmark class is using a Parquet writable object
> to run all write/read/serialize/deserialize tests. It would be better to use
> a more generic writable object (like text writables) to get better benchmark
> results between format storages.
> Using parquet writables may add advantage when writing parquet.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
