[
https://issues.apache.org/jira/browse/HIVE-9273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14297398#comment-14297398
]
Sushanth Sowmyan commented on HIVE-9273:
----------------------------------------
a) I like that you changed the return type to FireResponseType from void - that
allows for future growth if we need to ACK anything.
b) In the FireEventRequest thrift definition, I wondered about whether
tableName should really be optional, but I think that is important for future
listener events which might not map to table events exactly. But reasoning
along that line, shouldn't dbName also be optional? We could have
warehouse-level events we might want to fire.
c) Given that FireEventRequestData data in FireEventRequest is marked as
optional, I think there should be a null-guard on
HiveMetaStore.fire_listener_event when switching on
rqst.getData().getSetField() ?
d) This can be tackled as a separate bug, but we should fire a FireEventRequest
from HCatalog appends as well.
[~ashutoshc], could I have a backup review on the changes this patch makes to
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java ? To me, the changes
look reasonable, but I'm unsure if this is exhaustive in all the places we
would need to change to ensure we trigger this event for new files/data being
added to a table which does not result in a metadata change(i.e. append cases)
> Add option to fire metastore event on insert
> --------------------------------------------
>
> Key: HIVE-9273
> URL: https://issues.apache.org/jira/browse/HIVE-9273
> Project: Hive
> Issue Type: New Feature
> Reporter: Alan Gates
> Assignee: Alan Gates
> Attachments: HIVE-9273.patch
>
>
> HIVE-9271 adds the ability for the client to request firing metastore events.
> This can be used in the MoveTask to fire events when an insert is done that
> does not add partitions to a table.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
