[ 
https://issues.apache.org/jira/browse/HIVE-8379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sergio Peña updated HIVE-8379:
------------------------------
    Attachment: HIVE-8379.1.patch

Patch attached that makes the code more readable by using constants names 
specific to the nano time.

I run some JMH micro benchmark times look almost the same for both approaches.

> NanoTimeUtils performs some work needlessly
> -------------------------------------------
>
>                 Key: HIVE-8379
>                 URL: https://issues.apache.org/jira/browse/HIVE-8379
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Brock Noland
>            Assignee: Sergio Peña
>            Priority: Minor
>         Attachments: HIVE-8379.1.patch
>
>
> Portions of the math done with the constants can be pre-computed:
> https://github.com/apache/hive/blob/trunk/ql/src/java/org/apache/hadoop/hive/ql/io/parquet/timestamp/NanoTimeUtils.java#L70



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to