-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29898/
-----------------------------------------------------------

(Updated Jan. 31, 2015, 2:25 a.m.)


Review request for hive and Ashutosh Chauhan.


Changes
-------

changes per RB feedback:
- Add Joda to shade goal
- Use Long.parseLong() rather than BigDecimal
- change serdeConstants using thrift file
- Add separators/nullSequence/lastColumnTakesRest to lazy OI params, cuts down 
on the number of args in the various lazy methods.
- Change comma-delimited parsing


Bugs: HIVE-9298
    https://issues.apache.org/jira/browse/HIVE-9298


Repository: hive-git


Description
-------

Add new SerDe parameter "timestamp.formats" to specify alternate timestamp 
patterns


Diffs (updated)
-----

  common/pom.xml ccd4c2c 
  common/src/java/org/apache/hive/common/util/HiveStringUtils.java 8db2c2c 
  common/src/java/org/apache/hive/common/util/TimestampParser.java PRE-CREATION 
  common/src/test/org/apache/hive/common/util/TestHiveStringUtils.java 
PRE-CREATION 
  common/src/test/org/apache/hive/common/util/TestTimestampParser.java 
PRE-CREATION 
  data/files/ts_formats.txt PRE-CREATION 
  
hbase-handler/src/java/org/apache/hadoop/hive/hbase/DefaultHBaseKeyFactory.java 
98bc73f 
  
hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseLazyObjectFactory.java 
78f23cb 
  
hbase-handler/src/java/org/apache/hadoop/hive/hbase/struct/AvroHBaseValueFactory.java
 a2ba827 
  
hbase-handler/src/java/org/apache/hadoop/hive/hbase/struct/DefaultHBaseValueFactory.java
 e60b844 
  hbase-handler/src/test/queries/positive/hbase_timestamp_format.q PRE-CREATION 
  hbase-handler/src/test/results/positive/hbase_timestamp_format.q.out 
PRE-CREATION 
  pom.xml ecec5af 
  ql/pom.xml 87f79e2 
  ql/src/test/queries/clientpositive/timestamp_formats.q PRE-CREATION 
  ql/src/test/results/clientpositive/timestamp_formats.q.out PRE-CREATION 
  serde/if/serde.thrift 76f95b5 
  serde/src/gen/thrift/gen-cpp/serde_constants.h 1455382 
  serde/src/gen/thrift/gen-cpp/serde_constants.cpp bd5c16d 
  
serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/serdeConstants.java
 8d3595b 
  
serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/test/ThriftTestObj.java
 1b708dd 
  
serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/Complex.java
 07ea8b9 
  
serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/MegaStruct.java
 386fef9 
  
serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/PropValueUnion.java
 aa56dc9 
  
serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/SetIntString.java
 676f2b2 
  serde/src/gen/thrift/gen-php/org/apache/hadoop/hive/serde/Types.php 3c2f0a9 
  serde/src/gen/thrift/gen-py/org_apache_hadoop_hive_serde/constants.py 08ca294 
  serde/src/gen/thrift/gen-rb/serde_constants.rb 40375f5 
  
serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroLazyObjectInspector.java 
2fb1c28 
  serde/src/java/org/apache/hadoop/hive/serde2/columnar/ColumnarSerDe.java 
882c43e 
  serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java e3968a9 
  serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazySimpleSerDe.java 
95e30db 
  serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyTimestamp.java 27895c5 
  
serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyListObjectInspector.java
 9d66a78 
  
serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyMapObjectInspector.java
 ee870f5 
  
serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyObjectInspectorFactory.java
 1abd8a5 
  
serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazySimpleStructObjectInspector.java
 9611e9f 
  
serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyUnionObjectInspector.java
 792a9a2 
  
serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyObjectInspectorParameters.java
 PRE-CREATION 
  
serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyObjectInspectorParametersImpl.java
 PRE-CREATION 
  
serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyPrimitiveObjectInspectorFactory.java
 08fec77 
  
serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyTimestampObjectInspector.java
 0d15054 

Diff: https://reviews.apache.org/r/29898/diff/


Testing
-------

Added CliDriver/HBaseCliDriver qfile tests


Thanks,

Jason Dere

Reply via email to