> On Nov. 14, 2014, 9:24 p.m., Jason Dere wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g, line 1626 > > <https://reviews.apache.org/r/26854/diff/6/?file=762528#file762528line1626> > > > > The message here should be "reload function statement"
Fixed > On Nov. 14, 2014, 9:24 p.m., Jason Dere wrote: > > ql/src/java/org/apache/hadoop/hive/ql/session/SessionConf.java, line 24 > > <https://reviews.apache.org/r/26854/diff/6/?file=762534#file762534line24> > > > > What about the idea of moving static call to resolveFunctions() to > > SessionState? I thought that would remove the need for SessionConf, because > > then Hive class would once again be usable during query runtime. Unless you > > think it's cleaner to use SessionConf to get HiveConf rather than the Hive > > object. Done > On Nov. 14, 2014, 9:24 p.m., Jason Dere wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionTask.java, line 105 > > <https://reviews.apache.org/r/26854/diff/6/?file=762515#file762515line105> > > > > Ok, so this allows the persistent function list to be reloaded, with an > > explicit RELOAD command. This should work for now, I suppose it's always > > possible to add more automatic refreshing of functions later on if folks > > want that. Yes, let's do that in following issue. - Navis ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26854/#review61331 ----------------------------------------------------------- On Nov. 13, 2014, 10:15 p.m., Jason Dere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26854/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2014, 10:15 p.m.) > > > Review request for hive, Navis Ryu and Thejas Nair. > > > Bugs: HIVE-2573 > https://issues.apache.org/jira/browse/HIVE-2573 > > > Repository: hive-git > > > Description > ------- > > Small updates to Navis' changes: > - session registry doesn't lookup metastore for UDFs > - my feedback from Navis' original patch > - metastore udfs should not be considered native. This allows them to be > added/removed from registry > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/common/JavaUtils.java 9aa917c > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java cca57d2 > contrib/src/test/results/clientnegative/invalid_row_sequence.q.out 8f3c0b3 > > metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java > 88b0791 > ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java 292c83c > ql/src/java/org/apache/hadoop/hive/ql/exec/CommonFunctionInfo.java 93c15c0 > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionInfo.java 074255b > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 6323387 > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionTask.java 569c125 > ql/src/java/org/apache/hadoop/hive/ql/exec/Registry.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 913288f > ql/src/java/org/apache/hadoop/hive/ql/exec/WindowFunctionInfo.java efecb05 > ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java 18e40b3 > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java b900627 > ql/src/java/org/apache/hadoop/hive/ql/metadata/Partition.java 13277a9 > ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 211ab6c > ql/src/java/org/apache/hadoop/hive/ql/optimizer/IndexUtils.java e2768ff > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/SqlFunctionConverter.java > 7f52c29 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java > 4b2a81a > ql/src/java/org/apache/hadoop/hive/ql/parse/FunctionSemanticAnalyzer.java > 22e5b47 > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g f412010 > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g f1365fa > ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g c960a6b > ql/src/java/org/apache/hadoop/hive/ql/parse/IndexUpdater.java 2b239ab > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java > 6962ee9 > ql/src/java/org/apache/hadoop/hive/ql/plan/FunctionWork.java f968bc1 > ql/src/java/org/apache/hadoop/hive/ql/plan/ReloadFunctionDesc.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/session/SessionConf.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 2806bd1 > ql/src/test/org/apache/hadoop/hive/ql/parse/TestMacroSemanticAnalyzer.java > 46f8052 > ql/src/test/queries/clientnegative/drop_native_udf.q ae047bb > ql/src/test/results/clientnegative/create_function_nonexistent_class.q.out > c7405ed > ql/src/test/results/clientnegative/create_function_nonudf_class.q.out > d0dd50a > ql/src/test/results/clientnegative/drop_native_udf.q.out 9f0eaa5 > ql/src/test/results/clientnegative/udf_nonexistent_resource.q.out e184787 > > Diff: https://reviews.apache.org/r/26854/diff/ > > > Testing > ------- > > > Thanks, > > Jason Dere > >
