> On Feb. 25, 2015, 11:01 p.m., Xuefu Zhang wrote: > > I understand we are renaming a file, but it may be good also update the > > comments in the renamed file as well for consistency. > > Alexander Pivovarov wrote: > I checked again. I can not find name with typo ("Levenstein") in *.java, > *.q, *.q.out files > Xuefu, what line in GenericUDFLevenshtein.java you want me to fix? > > Xuefu Zhang wrote: > I was referring comment in original GenericUDFLevenstein.java file. It's > good if it's already fixed. > > /** > * GenericUDFLevenstein. > * > * This function calculates the Levenshtein distance between two strings. > * Levenshtein distance is a string metric for measuring the difference > between > * two sequences. Informally, the Levenshtein distance between two words > is the > * minimum number of single-character edits (i.e. insertions, deletions or > * substitutions) required to change one word into the other. It is named > after > * Vladimir Levenshtein, who considered this distance in 1965 > * > */ > > Alexander Pivovarov wrote: > I think there was no typo in comments...
what about "/* GenericUDFLevenstein. */? The class name in the comment. - Xuefu ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31316/#review74130 ----------------------------------------------------------- On Feb. 25, 2015, 11:23 p.m., Alexander Pivovarov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31316/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2015, 11:23 p.m.) > > > Review request for hive, Jason Dere and Xuefu Zhang. > > > Bugs: HIVE-9754 > https://issues.apache.org/jira/browse/HIVE-9754 > > > Repository: hive-git > > > Description > ------- > > HIVE-9754 rename GenericUDFLevenstein to GenericUDFLevenshtein > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java > bfeb33c9edf79071bf106a3780e1c6bc21be3753 > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLevenstein.java > de41793ba3925aa9e1ad9623d92881c57791f047 > > ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFLevenshtein.java > e674d9f38cf7b5cdffcad6eca07dba74ff1e834b > > Diff: https://reviews.apache.org/r/31316/diff/ > > > Testing > ------- > > > Thanks, > > Alexander Pivovarov > >