> On Feb. 26, 2015, 2:53 p.m., Xuefu Zhang wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/RemoteHiveSparkClient.java, > > line 152 > > <https://reviews.apache.org/r/31452/diff/1/?file=877054#file877054line152> > > > > Could we rename this variable for better readability?
Sure. - Jimmy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31452/#review74273 ----------------------------------------------------------- On Feb. 26, 2015, 1:42 a.m., Jimmy Xiang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31452/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2015, 1:42 a.m.) > > > Review request for hive, Brock Noland and Xuefu Zhang. > > > Bugs: HIVE-9781 > https://issues.apache.org/jira/browse/HIVE-9781 > > > Repository: hive-git > > > Description > ------- > > Now, Spark RSC can use setting spark.kryo.classesToRegister. Reference > checking is still needed since there are loops. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/KryoSerializer.java > 76a4fd1 > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/RemoteHiveSparkClient.java > f1d65ea > > Diff: https://reviews.apache.org/r/31452/diff/ > > > Testing > ------- > > Tested it on a yarn cluster with spark.kryo.classesToRegister set. > > > Thanks, > > Jimmy Xiang > >
