----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31404/#review74584 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDF.java <https://reviews.apache.org/r/31404/#comment121194> Hmm, this member ends up being a part of all GenericUDFs, but is only used by the methods that use these new convertDate methods. Makes me wonder if we should package these changes (plus array of Converters) as a separate utility class. What do you think of that? Not a necessary change, we can leave it as it is and can always revisit this later. - Jason Dere On Feb. 27, 2015, 12:11 a.m., Alexander Pivovarov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31404/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2015, 12:11 a.m.) > > > Review request for hive, Jason Dere and Thejas Nair. > > > Bugs: HIVE-9744 > https://issues.apache.org/jira/browse/HIVE-9744 > > > Repository: hive-git > > > Description > ------- > > HIVE-9744 Move common arguments validation and value extraction code to > GenericUDF > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDF.java > 8a0f573648c51c4945be8ffec4a0b06dfa7061c8 > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAddMonths.java > c5968835a74195bea6b31a5c7b7346907fed5ce0 > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFInitCap.java > 406fcd608a13fadb8902bf273932acb05a0f3bbe > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLastDay.java > 3a43c571ae3a83924a00413181a62ce6f4408125 > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLevenstein.java > de41793ba3925aa9e1ad9623d92881c57791f047 > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFNextDay.java > 38f08b74609a4018221ca3f5b92cf33799604d60 > > ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFAddMonths.java > 4ccae97a227257294d69f728426f425d060ef0c7 > > ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFLastDay.java > 4b233a6966bbdf6902c53f2aaf53cc0eb422b205 > > ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFLevenshtein.java > e674d9f38cf7b5cdffcad6eca07dba74ff1e834b > > ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFNextDay.java > e2ec551d4ae39d521680ee93c791f14f27811270 > ql/src/test/results/clientnegative/udf_add_months_error_1.q.out > 8226ac6fe89c38fcc14edeea215cd5cce7258683 > ql/src/test/results/clientnegative/udf_add_months_error_2.q.out > f00949e9a12285cc91032215372975753c1f3b4a > ql/src/test/results/clientnegative/udf_last_day_error_1.q.out > 6e718a0c15e84d89b1cfe7f36231e472ff03c37f > ql/src/test/results/clientnegative/udf_last_day_error_2.q.out > dc8e3d14f14205ce65355cd53a95cfc788f45fe0 > ql/src/test/results/clientnegative/udf_next_day_error_1.q.out > c67b9c42f7e7fdf20caa34d028b02fd4819e8343 > ql/src/test/results/clientnegative/udf_next_day_error_2.q.out > e3cb6a447bf7bd9f09648e46ace1bcba4da55339 > > Diff: https://reviews.apache.org/r/31404/diff/ > > > Testing > ------- > > > Thanks, > > Alexander Pivovarov > >